fix: remaining issues in the test suite following the upgrade to kokkos-5.1#382
Conversation
svalat
force-pushed
the
fix/kokkos5.1-volatile-issue
branch
from
d2e172a to
87ca9cd
Compare
…e on recent compiler)
svalat
force-pushed
the
fix/kokkos5.1-volatile-issue
branch
from
87ca9cd to
1baed7a
Compare
svalat
changed the title
svalat
changed the title
| # note that no version of inifix supports Python older than 3.6 | ||
| inifix>=0.11.2 | ||
|
|
||
| # It supports Python 3.8 as minimum. |
There was a problem hiding this comment.
This comment makes the one I added to inifix redundant.
While this is being looked at, could we specify a minimal requirement for Python itself, even if it's just a comment ?
3.11 is widely distributed and likely sufficient nowadays, if I may add a suggestion.
There was a problem hiding this comment.
I'm assuming you're refereing to #381 ? I don't see how this comment make yours redundant,nor why we should require python 3.11 (this is only 4 years old)
There was a problem hiding this comment.
no I'm talking about the comment on line 9 of the same file. It doesn't matter any more that inifix requires 3.6+ if another dependency requires an even newer version.
(this is only 4 years old)
Python versions stop receiving security fixes after 5 years, and 3.10 is about to go EOL. That's why I don't recommend older versions. But of course you do you.
https://devguide.python.org/versions/
3 participants
This PR contains several fixes to make the test suite passing again after the upgrade to kokkos-5.1 :
volatilekeyword in anoperator+=test/python_requirements.txtas it is used by some testsHostMirror=>host_mirror_typeThe test suite is now passing again.